4346 Enhance contribution guide for optional package#4367
Merged
Conversation
merge master
merge master
merge master
merge master
merge master
merge master
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
ericspod
reviewed
May 27, 2022
ericspod
reviewed
May 27, 2022
wyli
reviewed
May 27, 2022
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli
force-pushed
the
4346-enhance-contribution-doc
branch
from
bb0d751 to
1230cc5
Compare
wyli
approved these changes
May 27, 2022
wyli
left a comment
wyli
left a comment
Contributor
There was a problem hiding this comment.
added some more info, please feel free to revise...
Nic-Ma
changed the title
Contributor
Author
|
/black |
Contributor
Author
|
/build |
1 similar comment
Contributor
Author
|
/build |
Contributor
Author
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4346 .
Description
According to the feedback from several recent new contributors, this PR added the description for optional package.
And also fixed a link error in
installation.mddoc.Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.